From reviews-return-86622-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Mar 27 06:09:04 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E54D419E53 for ; Wed, 27 Mar 2019 06:09:03 +0000 (UTC) Received: (qmail 89860 invoked by uid 500); 27 Mar 2019 06:09:03 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 89823 invoked by uid 500); 27 Mar 2019 06:09:03 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 89799 invoked by uid 99); 27 Mar 2019 06:09:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Mar 2019 06:09:02 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 80784E0339; Wed, 27 Mar 2019 06:09:02 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 6E3BAC40479; Wed, 27 Mar 2019 06:09:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0223868445875226302==" MIME-Version: 1.0 Subject: Review Request 70321: Cleaned up `mesos::csi::v0::Client` interface. From: Chun-Hung Hsiao To: Benjamin Bannier , Jie Yu , Jan Schlicht Cc: Chun-Hung Hsiao , mesos Date: Wed, 27 Mar 2019 06:09:02 -0000 Message-ID: <20190327060902.64515.66078@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Chun-Hung Hsiao X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/70321/ X-Sender: Chun-Hung Hsiao X-ReviewBoard-Diff-For: src/csi/v0_client.hpp X-ReviewBoard-Diff-For: src/csi/rpc.hpp X-ReviewBoard-Diff-For: src/csi/client.hpp X-ReviewBoard-Diff-For: src/csi/v0_volume_manager.cpp X-ReviewBoard-Diff-For: src/csi/v0_volume_manager_process.hpp X-ReviewBoard-Diff-For: src/csi/service_manager.cpp X-ReviewBoard-Diff-For: src/csi/v0_client.cpp X-ReviewBoard-Diff-For: src/csi/client.cpp X-ReviewBoard-Diff-For: src/csi/rpc.cpp Reply-To: Chun-Hung Hsiao X-ReviewRequest-Repository: mesos --===============0223868445875226302== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70321/ ----------------------------------------------------------- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: MESOS-9624 https://issues.apache.org/jira/browse/MESOS-9624 Repository: mesos Description ------- Since per-CSI-call metrics are no longer implemented, there is very less value to keep the `mesos::csi::v0::RPC` enum, which is tightly coupled with `mesos::csi::v0::Client`. Therefore, the enum and its header are removed. The header and implementation file for `mesos::csi::v0::Client` is also renamed for future CSI v1 support. Diffs ----- src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2 src/Makefile.am bcafe48b2105575371464a29783bc6f3f1c2cf8d src/csi/client.hpp c2583cf4c0d2abc38d65ddc801cae3696a8080a9 src/csi/client.cpp 9e17f5bcb902470045dac704f2471d2962336e48 src/csi/rpc.hpp b2502ceb319638038b4d151965f6226db675f96b src/csi/rpc.cpp e8a2770a6d8ae48a717ed93fa872e9edee45e618 src/csi/service_manager.cpp PRE-CREATION src/csi/v0_client.hpp PRE-CREATION src/csi/v0_volume_manager.cpp PRE-CREATION src/csi/v0_volume_manager_process.hpp PRE-CREATION src/tests/csi_client_tests.cpp c8f3f04e6bff40d62dd0f85fcc146d71fa9e5d34 src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87 Diff: https://reviews.apache.org/r/70321/diff/1/ Testing ------- make check Thanks, Chun-Hung Hsiao --===============0223868445875226302==--