From reviews-return-85993-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Mar 6 14:06:15 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A301118D1B for ; Wed, 6 Mar 2019 14:06:15 +0000 (UTC) Received: (qmail 42753 invoked by uid 500); 6 Mar 2019 14:03:22 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 42737 invoked by uid 500); 6 Mar 2019 14:03:22 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 42483 invoked by uid 99); 6 Mar 2019 14:03:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Mar 2019 14:03:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A1F3AC72DF; Wed, 6 Mar 2019 14:03:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.402 X-Spam-Level: *** X-Spam-Status: No, score=3.402 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Zx-rMkjmL-3t; Wed, 6 Mar 2019 14:03:20 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id EE6005F58F; Wed, 6 Mar 2019 14:03:19 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 26CA9E01AC; Wed, 6 Mar 2019 14:03:19 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 0A73FC4027E; Wed, 6 Mar 2019 14:03:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1326669235059478946==" MIME-Version: 1.0 Subject: Re: Review Request 70137: Made volume gid manager allocate & deallocate gid to non-shared PV. From: Qian Zhang To: Andrei Budnik Cc: Qian Zhang , mesos Date: Wed, 06 Mar 2019 14:03:19 -0000 Message-ID: <20190306140319.44281.69320@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Qian Zhang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/70137/ X-Sender: Qian Zhang References: <20190306140247.44282.36774@reviews-vm2.apache.org> In-Reply-To: <20190306140247.44282.36774@reviews-vm2.apache.org> Reply-To: Qian Zhang X-ReviewRequest-Repository: mesos --===============1326669235059478946== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70137/ ----------------------------------------------------------- (Updated March 6, 2019, 10:03 p.m.) Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-8813 https://issues.apache.org/jira/browse/MESOS-8813 Repository: mesos Description ------- Made volume gid manager allocate & deallocate gid to non-shared PV. Diffs ----- src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 341853a2df74f6ec3135e942b59a5da9d8f8460e src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 08449e269b550ba41f63b909ffbd5f7a7a83e32b src/slave/slave.cpp f9b58175ad5433bdfc15a312dfce6e972dea7fa3 Diff: https://reviews.apache.org/r/70137/diff/1/ Testing ------- Thanks, Qian Zhang --===============1326669235059478946==--