From reviews-return-85962-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Mar 6 01:08:56 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 305341893B for ; Wed, 6 Mar 2019 01:08:56 +0000 (UTC) Received: (qmail 61426 invoked by uid 500); 6 Mar 2019 01:08:56 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 61395 invoked by uid 500); 6 Mar 2019 01:08:56 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 61383 invoked by uid 99); 6 Mar 2019 01:08:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Mar 2019 01:08:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id EF282C6FCC; Wed, 6 Mar 2019 01:08:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.951 X-Spam-Level: X-Spam-Status: No, score=0.951 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id R_GyvZFElted; Wed, 6 Mar 2019 01:08:53 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 71A5E5F1CF; Wed, 6 Mar 2019 01:08:53 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D59DBE092E; Wed, 6 Mar 2019 01:08:52 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id B8B03C4027E; Wed, 6 Mar 2019 01:08:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2104317066655851375==" MIME-Version: 1.0 Subject: Re: Review Request 69615: Disable containerizer ptrace attach. From: James Peach To: Xudong Ni , Jie Yu , Jiang Yan Xu Cc: Mesos Reviewbot , Mesos Reviewbot Windows , Andrei Budnik , James Peach , mesos Date: Wed, 06 Mar 2019 01:08:52 -0000 Message-ID: <20190306010852.32010.33075@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: James Peach X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/69615/ X-Sender: James Peach References: <20190208210908.23291.24147@reviews-vm2.apache.org> In-Reply-To: <20190208210908.23291.24147@reviews-vm2.apache.org> Reply-To: James Peach X-ReviewRequest-Repository: mesos --===============2104317066655851375== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/ ----------------------------------------------------------- (Updated March 6, 2019, 1:08 a.m.) Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu. Bugs: MESOS-9349 https://issues.apache.org/jira/browse/MESOS-9349 Repository: mesos Description ------- Use `prctl(PR_SET_DUMPABLE)` to disable the ability to attach to the containerizer process(es) on Linux systems. This prevents unprivileged containerized processes from reading information about the containerizer process(es) from `/proc`. This gives an additional layer of protection against leaking information to untrusted container processes. Diffs (updated) ----- docs/configuration/agent.md e744c3caaf1f5c3ed274b622f2fe3eacb60096b2 src/launcher/executor.cpp fa4bcaad9ac36bf380484dadb14d0b0a86a30aae src/slave/containerizer/mesos/containerizer.cpp 043244841a73fa3f5f7119bc38f6d3a04be8990b src/slave/containerizer/mesos/launch.hpp 0a6394d56321948ad760ac69c05456319a254842 src/slave/containerizer/mesos/launch.cpp 88b97a572916defbe65692036be77395053eb8e8 src/slave/flags.hpp 09921cb6172202b5c1d2f8d03f9ccaeb3d0e8c94 src/slave/flags.cpp 5fe5e05ddfc92ae0da4ce9c934cd713312a1e46e src/slave/slave.cpp 4073d8a0954932318b5b37a7b7fa02d7b336840a src/tests/containerizer/mesos_containerizer_tests.cpp 449928c10b897061642af8ad267f8b70695940e6 src/tests/slave_tests.cpp 22a0295086ae4f4ec26df00a0e077eecfa27f1fb Diff: https://reviews.apache.org/r/69615/diff/4/ Changes: https://reviews.apache.org/r/69615/diff/3-4/ Testing ------- make check (Fedora 29) Thanks, James Peach --===============2104317066655851375==--