From reviews-return-85954-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Mar 5 22:49:11 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7ED5B181C5 for ; Tue, 5 Mar 2019 22:49:11 +0000 (UTC) Received: (qmail 68126 invoked by uid 500); 5 Mar 2019 22:49:11 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 68098 invoked by uid 500); 5 Mar 2019 22:49:11 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 68065 invoked by uid 99); 5 Mar 2019 22:49:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Mar 2019 22:49:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5784EC2D7F; Tue, 5 Mar 2019 22:49:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.701 X-Spam-Level: X-Spam-Status: No, score=0.701 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id m_p4T34o71P0; Tue, 5 Mar 2019 22:49:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 18F9B5F54E; Tue, 5 Mar 2019 22:25:31 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 45691E092E; Tue, 5 Mar 2019 22:25:30 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 280ECC402C4; Tue, 5 Mar 2019 22:25:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0912691260836546796==" MIME-Version: 1.0 Subject: Re: Review Request 70123: Added rvalue overload for `Result::get()`. From: Benjamin Bannier To: Benjamin Bannier , Benjamin Mahler Cc: Meng Zhu , mesos Date: Tue, 05 Mar 2019 22:25:30 -0000 Message-ID: <20190305222530.23706.84497@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Bannier X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/70123/ X-Sender: Benjamin Bannier References: <20190305220932.32010.39712@reviews-vm2.apache.org> In-Reply-To: <20190305220932.32010.39712@reviews-vm2.apache.org> Reply-To: Benjamin Bannier X-ReviewRequest-Repository: mesos --===============0912691260836546796== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On March 5, 2019, 11:09 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/result.hpp > > Line 126 (original), 140 (patched) > > > > > > The `mesos-redundant-get` clang-tidy check will incorrectly suggest to use `std::forward(self).data->get()` here which I am not sure how to fix (this function will work on both rvalue and lvalue `self` values which AFAICT don't propagate the same way through `operator->`. > > > > I'd suggest we add a linter suppression here for now until we possibly get rid of `get` in favor of `operator*` for good. > > ``` > > return std::forward(self) > > .data > > .get() // NOLINT(mesos-redundant-get) > > .get(); > > ``` Actually there's also `NOLINTNEXTLINT` which would allow us to keep the expression on a single line, e.g., ``` // NOTLINENEXTLINE(mesos-redundant-get) return std::forward(self).data.get().get() ``` Also above. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70123/#review213433 ----------------------------------------------------------- On March 5, 2019, 12:53 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70123/ > ----------------------------------------------------------- > > (Updated March 5, 2019, 12:53 a.m.) > > > Review request for mesos, Benjamin Bannier and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Added rvalue overload for `Result::get()`. > > > Diffs > ----- > > 3rdparty/stout/include/stout/result.hpp c1387ae957edffc31250b9b236b5f1fd8ff0acd3 > > > Diff: https://reviews.apache.org/r/70123/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > > --===============0912691260836546796==--