From reviews-return-85935-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Mar 5 07:32:21 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7B61318363 for ; Tue, 5 Mar 2019 07:32:21 +0000 (UTC) Received: (qmail 49691 invoked by uid 500); 5 Mar 2019 07:32:21 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 49595 invoked by uid 500); 5 Mar 2019 07:32:21 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 49584 invoked by uid 99); 5 Mar 2019 07:32:20 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Mar 2019 07:32:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id EE93A18546C; Tue, 5 Mar 2019 07:32:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.152 X-Spam-Level: *** X-Spam-Status: No, score=3.152 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id wRakr4e7UpqK; Tue, 5 Mar 2019 07:32:18 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 6C5A860FAC; Tue, 5 Mar 2019 07:32:18 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D4C88E0D27; Tue, 5 Mar 2019 07:32:17 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 93BAFC4034C; Tue, 5 Mar 2019 07:32:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7941305716469767772==" MIME-Version: 1.0 Subject: Re: Review Request 70114: Added logging for `linux/seccomp` isolator. From: Gilbert Song To: Qian Zhang Cc: Andrei Budnik , mesos Date: Tue, 05 Mar 2019 07:32:17 -0000 Message-ID: <20190305073217.32010.53780@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gilbert Song X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/70114/ X-Sender: Gilbert Song X-ReviewBoard-ShipIt: 1 References: <20190304145901.25876.8014@reviews-vm2.apache.org> In-Reply-To: <20190304145901.25876.8014@reviews-vm2.apache.org> Reply-To: Gilbert Song X-ReviewRequest-Repository: mesos --===============7941305716469767772== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70114/#review213428 ----------------------------------------------------------- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/linux/seccomp.cpp Lines 110-111 (patched) I would probably move it down to L126 for print the path for all seccomp profile cases. - Gilbert Song On March 4, 2019, 6:59 a.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70114/ > ----------------------------------------------------------- > > (Updated March 4, 2019, 6:59 a.m.) > > > Review request for mesos, Gilbert Song and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Added logging for `linux/seccomp` isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/linux/seccomp.cpp 1c94e126a0a5039e46d0e7696f4e629d41b35d50 > > > Diff: https://reviews.apache.org/r/70114/diff/1/ > > > Testing > ------- > > None: not a functional change. > > > Thanks, > > Andrei Budnik > > --===============7941305716469767772==--