From reviews-return-85912-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Mar 4 19:15:37 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 43274184B8 for ; Mon, 4 Mar 2019 19:15:37 +0000 (UTC) Received: (qmail 57226 invoked by uid 500); 4 Mar 2019 19:15:37 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 57196 invoked by uid 500); 4 Mar 2019 19:15:37 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 57178 invoked by uid 99); 4 Mar 2019 19:15:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Mar 2019 19:15:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 132C718481C; Mon, 4 Mar 2019 19:15:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.7 X-Spam-Level: X-Spam-Status: No, score=0.7 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Np3j4yKuyS6J; Mon, 4 Mar 2019 19:15:34 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 9589A5F41C; Mon, 4 Mar 2019 19:15:34 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 15912E0C57; Mon, 4 Mar 2019 19:15:34 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id D706AC4027D; Mon, 4 Mar 2019 19:15:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6099668531311114512==" MIME-Version: 1.0 Subject: Re: Review Request 69588: Removed outdated authorization logic for offer operations. From: Chun-Hung Hsiao To: Benjamin Bannier , Benjamin Mahler , Michael Park , Till Toenshoff Cc: Mesos Reviewbot , Mesos Reviewbot Windows , mesos , Chun-Hung Hsiao Date: Mon, 04 Mar 2019 19:15:33 -0000 Message-ID: <20190304191533.25876.14402@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Chun-Hung Hsiao X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/69588/ X-Sender: Chun-Hung Hsiao References: <20190303062111.54207.86741@reviews-vm2.apache.org> In-Reply-To: <20190303062111.54207.86741@reviews-vm2.apache.org> Reply-To: Chun-Hung Hsiao X-ReviewRequest-Repository: mesos --===============6099668531311114512== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69588/ ----------------------------------------------------------- (Updated March 4, 2019, 7:15 p.m.) Review request for mesos, Benjamin Bannier, Benjamin Mahler, Michael Park, and Till Toenshoff. Changes ------- Wrapped the commit message at 72 chars. Repository: mesos Description (updated) ------- Since the master now upgrades resources to the post-reservation-refinement format before authorization (see MESOS-7735), the authorization logic in the master becomes outdated. This patch cleans it up. Diffs (updated) ----- src/master/master.cpp 015da54583448a8d102d8e401e48bd228baf6dd6 Diff: https://reviews.apache.org/r/69588/diff/4/ Changes: https://reviews.apache.org/r/69588/diff/3-4/ Testing ------- sudo make check Thanks, Chun-Hung Hsiao --===============6099668531311114512==--