From reviews-return-85907-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Mar 4 17:01:17 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 92D0718E0E for ; Mon, 4 Mar 2019 17:01:17 +0000 (UTC) Received: (qmail 56093 invoked by uid 500); 4 Mar 2019 17:01:17 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 56067 invoked by uid 500); 4 Mar 2019 17:01:17 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 56055 invoked by uid 99); 4 Mar 2019 17:01:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Mar 2019 17:01:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 62C0CCA929; Mon, 4 Mar 2019 17:01:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.448 X-Spam-Level: *** X-Spam-Status: No, score=3.448 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, SUSPICIOUS_RECIPS=2.497] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id kXQPiDppmjZq; Mon, 4 Mar 2019 17:01:15 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 20BD960E03; Mon, 4 Mar 2019 17:01:14 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 45FE2E0D27; Mon, 4 Mar 2019 17:01:13 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 281C2C4027D; Mon, 4 Mar 2019 17:01:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1286490124629810752==" MIME-Version: 1.0 Subject: Review Request 70116: Added metrics for offer operation feedback. From: Benno Evers To: =?utf-8?q?Gast=C3=B3n_Kleiman?= , Joseph Wu , Greg Mann Cc: Benno Evers , mesos Date: Mon, 04 Mar 2019 17:01:13 -0000 Message-ID: <20190304170113.25876.28340@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benno Evers X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/70116/ X-Sender: Benno Evers Reply-To: Benno Evers X-ReviewRequest-Repository: mesos --===============1286490124629810752== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70116/ ----------------------------------------------------------- Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu. Bugs: MESOS-8241 https://issues.apache.org/jira/browse/MESOS-8241 Repository: mesos Description ------- This commit adds the following additional metrics to the master: - master/operations_pending - master/operations_recovering - master/operations_finished - master/operations_failed - master/operations_error - master/operations_dropped - master/operations_unreachable - master/operations_gone_by_operator Unit tests are added in the subsequent commit. Diffs ----- src/master/master.hpp aceab3455adfdf7ff6e168e033316997a4d36fb5 src/master/master.cpp 665c1c7979a5ae4ecec0d5a68e59c5419049a4d5 src/master/metrics.hpp 4495e65b6bb11f7236335a702c4f61e7c3f9b0aa src/master/metrics.cpp 4dd73fb18a06ce8f75c4c1435dba84ade123bee9 Diff: https://reviews.apache.org/r/70116/diff/1/ Testing ------- Thanks, Benno Evers --===============1286490124629810752==--