From reviews-return-85898-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Mar 4 12:54:36 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9D10618F18 for ; Mon, 4 Mar 2019 12:54:36 +0000 (UTC) Received: (qmail 5467 invoked by uid 500); 4 Mar 2019 12:54:36 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 5424 invoked by uid 500); 4 Mar 2019 12:54:36 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 5393 invoked by uid 99); 4 Mar 2019 12:54:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Mar 2019 12:54:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 59B75182E11; Mon, 4 Mar 2019 12:54:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.701 X-Spam-Level: X-Spam-Status: No, score=0.701 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id b0oG36-1Cmbh; Mon, 4 Mar 2019 12:54:34 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id AA7505F1BE; Mon, 4 Mar 2019 12:54:33 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D424DE01AC; Mon, 4 Mar 2019 12:54:32 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A3246C4027B; Mon, 4 Mar 2019 12:54:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4488811101273916468==" MIME-Version: 1.0 Subject: Re: Review Request 69954: Added a SLRP unit test for persistent block volume creation. From: Benjamin Bannier To: Benjamin Bannier Cc: Chun-Hung Hsiao , mesos Date: Mon, 04 Mar 2019 12:54:32 -0000 Message-ID: <20190304125432.25876.50074@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Bannier X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/69954/ X-Sender: Benjamin Bannier References: <20190212052750.10671.86858@reviews-vm2.apache.org> In-Reply-To: <20190212052750.10671.86858@reviews-vm2.apache.org> Reply-To: Benjamin Bannier X-ReviewRequest-Repository: mesos --===============4488811101273916468== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69954/#review213397 ----------------------------------------------------------- Could you rebase this patch? - Benjamin Bannier On Feb. 12, 2019, 6:27 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69954/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2019, 6:27 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-9565 > https://issues.apache.org/jira/browse/MESOS-9565 > > > Repository: mesos > > > Description > ------- > > Test `CreateDestroyPersistentBlockVolume` verifies that SLRP would fail > a `CREATE` operation on a BLOCK disk resource, and a followup `DESTROY` > will be dropped (instead of failing the SLRP). > > > Diffs > ----- > > src/tests/mock_csi_plugin.cpp 10245705ab39872da0fef1afd02213e2c7f345cb > src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a > > > Diff: https://reviews.apache.org/r/69954/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > > --===============4488811101273916468==--