mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI versions.
Date Fri, 29 Mar 2019 23:50:28 GMT


> On March 28, 2019, 9:23 a.m., Benjamin Bannier wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Line 4139 (original), 4139 (patched)
> > <https://reviews.apache.org/r/70225/diff/6/?file=2135923#file2135923line4139>
> >
> >     Do you think it would make sense to put the value from intitial setup into a
constant and then simply reference it? Something like
> >     ```
> >     const size_t finished = 9;
> >     
> >     // ...
> >     
> >     EXPECT_EQ(finished + 2, snapshot.values.at(metricName("csi_plugin/rpcs_finished"));
> >     ```

Sounds a great idea!


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70225/#review214165
-----------------------------------------------------------


On March 28, 2019, 8 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70225/
> -----------------------------------------------------------
> 
> (Updated March 28, 2019, 8 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9639
>     https://issues.apache.org/jira/browse/MESOS-9639
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since the fine-grained version-specific per-CSI-call metrics are not
> very useful for operators, and most informations are highly correlated
> to per-operation metrics, these metrics are aggregated and made CSI
> version agnostic.
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md 54b872f579dbc68ca5f67f4cc1ba34065a09aee2 
>   src/csi/metrics.hpp PRE-CREATION 
>   src/csi/metrics.cpp PRE-CREATION 
>   src/csi/service_manager.cpp PRE-CREATION 
>   src/csi/v0_volume_manager.cpp PRE-CREATION 
>   src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87

> 
> 
> Diff: https://reviews.apache.org/r/70225/diff/6/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message