mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 70320: Used `ResourceQuantities` in `__allocate()` when appropriate.
Date Fri, 29 Mar 2019 23:22:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70320/
-----------------------------------------------------------

(Updated March 29, 2019, 4:22 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Addressed Ben's comment.


Bugs: MESOS-9504
    https://issues.apache.org/jira/browse/MESOS-9504


Repository: mesos


Description
-------

Replaced `Resources` with `ResourceQuantities` when
appropriate in `__allocate()`. This simplifies the
code and improves performance.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.hpp 36bf90baf413e99c1580d516dfac0f074335d322 
  src/master/allocator/mesos/hierarchical.cpp ef4f968a94d3a23c010202e27cc48cd10bbec2c0 


Diff: https://reviews.apache.org/r/70320/diff/3/

Changes: https://reviews.apache.org/r/70320/diff/2-3/


Testing
-------

make check
Benchmark results in r/70330


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message