mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <>
Subject Re: Review Request 70216: Cleanup the recovery logic for refactoring SLRP.
Date Thu, 28 Mar 2019 07:55:18 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 28, 2019, 7:55 a.m.)

Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Addressed Benjamin's comments.

Bugs: MESOS-9622

Repository: mesos


In addition to perform volume state recovery, the `recoverVolumes`
function also recovers service manager and preparing services now. The
whole logic will be moved out from SLRP to v0 `VolumeManager` later.

During volume state recovery, we no longer recover all volumes to steady
states, since transient states are properly handled in SLRP. To simplify
the recovery logic, a `publishVolume` method that conforms to the volume
manager's `publishVolume` is introduced.

Diffs (updated)

  src/resource_provider/storage/provider.cpp 2711503cdb58cb9b34af8c9fad0908c5f788a2af 
  src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93




make check


Chun-Hung Hsiao

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message