mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70247: Added an "unversioned" `VolumeCapability`.
Date Thu, 28 Mar 2019 07:51:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70247/
-----------------------------------------------------------

(Updated March 28, 2019, 7:51 a.m.)


Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan Schlicht.


Changes
-------

Adapted the `MessageDifferencer`.


Bugs: MESOS-9625
    https://issues.apache.org/jira/browse/MESOS-9625


Repository: mesos


Description
-------

To support both CSI v0 and v1, the "unversioned" `VolumeCapability` is
designed to satisfy the following compatibility guarantees:

1. The unversioned `VolumeCapability` parsed from a versioned one should
   be able to used to reconstruct the original versioned
   `VolumeCapability`, and can be upgraded/downgraded to a different
   CSI version and preserve as much semantics as possible.

2. If an backward-incompatible change is introduced in future CSI
   `VolumeCapability`, the unversioned `VolumeCapability` can provide a
   way to do a backward compatible upgrade.


Diffs (updated)
-----

  include/mesos/csi/types.hpp PRE-CREATION 
  include/mesos/csi/types.proto PRE-CREATION 
  src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2 
  src/Makefile.am bcafe48b2105575371464a29783bc6f3f1c2cf8d 
  src/csi/types.cpp PRE-CREATION 
  src/csi/utils.hpp 9145c6795c3ecdde5de5859a852763fe9aeb1ddf 
  src/csi/utils.cpp fd6f95d88caf69e2ae197cf940beb93c164565bc 
  src/tests/CMakeLists.txt ab7f6c2027d937038ee70145705b699c4fb8f05c 
  src/tests/csi_utils_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/70247/diff/5/

Changes: https://reviews.apache.org/r/70247/diff/4-5/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message