mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70316: Updated test `ImportPreprovisionedVolume` for better code coverage.
Date Thu, 28 Mar 2019 05:15:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70316/
-----------------------------------------------------------

(Updated March 28, 2019, 5:15 a.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Changes
-------

Addressed Benjamin's comments and fixed a flake.


Bugs: MESOS-9540
    https://issues.apache.org/jira/browse/MESOS-9540


Repository: mesos


Description
-------

This patch renames `ImportPreprovisionedVolume` to
`CreateDestroyPreprovisionedVolume` add tests two additional scenarios:

* `CREATE_DISK` with an unknown profile.

* `DESTROY_DISK` with a `RAW` disk.


Diffs (updated)
-----

  src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87



Diff: https://reviews.apache.org/r/70316/diff/3/

Changes: https://reviews.apache.org/r/70316/diff/2-3/


Testing (updated)
-------

make check

Ran 1000 times.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message