mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70315: Added authorization for applying `DESTROY_DISK` on `RAW` disks.
Date Thu, 28 Mar 2019 05:13:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70315/
-----------------------------------------------------------

(Updated March 28, 2019, 5:13 a.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Changes
-------

Addressed Benjamin's comments.


Bugs: MESOS-9540
    https://issues.apache.org/jira/browse/MESOS-9540


Repository: mesos


Description
-------

Added authorization for applying `DESTROY_DISK` on `RAW` disks.


Diffs (updated)
-----

  docs/examples/acls_template.json ad28cb80a504e9c3ef3167b87dc9b285f3832ffa 
  include/mesos/authorizer/acls.proto 4c3f2907a25c2920a0f382e3937898774bbf49fd 
  include/mesos/authorizer/authorizer.proto f9060531cf1f6bc60786e6d6e6b87310f1bc0927 
  src/authorizer/local/authorizer.cpp 85e18b958932fca74f7860bb19b178835a1636f9 
  src/master/master.cpp c519d5a350208556bdf55c63daae38da745ddfc6 
  src/tests/authorization_tests.cpp e85cdb681ae2d1a9f215ce9d07a56e85346e3dab 


Diff: https://reviews.apache.org/r/70315/diff/2/

Changes: https://reviews.apache.org/r/70315/diff/1-2/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message