mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70314: Supported destroying preprovisioned CSI volumes in SLRP.
Date Thu, 28 Mar 2019 05:11:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70314/
-----------------------------------------------------------

(Updated March 28, 2019, 5:11 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
-------

Addressed Benjamin's comments.


Bugs: MESOS-9540
    https://issues.apache.org/jira/browse/MESOS-9540


Repository: mesos


Description
-------

SLRP now accepts `DESTROY_DISK` on `RAW` disk resources with source IDs.
If the backed CSI plugin does have the `CREATE_DELETE_VOLUME` controller
capability, this operation will be a no-op; otherwise the underlying CSI
volume will be deprovisioned.


Diffs (updated)
-----

  src/resource_provider/storage/provider.cpp 2711503cdb58cb9b34af8c9fad0908c5f788a2af 


Diff: https://reviews.apache.org/r/70314/diff/3/

Changes: https://reviews.apache.org/r/70314/diff/2-3/


Testing
-------

make check

The new code path is tested later in this chain.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message