mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70295: Enabled launcher sealing for RPM packages.
Date Wed, 27 Mar 2019 18:28:03 GMT


> On March 26, 2019, 2:21 a.m., Joseph Wu wrote:
> > support/packaging/centos/mesos.spec
> > Lines 94 (patched)
> > <https://reviews.apache.org/r/70295/diff/1/?file=2133927#file2133927line94>
> >
> >     I'd expect the `--disable-libtool-wrappers` flag too, but do rpm builds omit
libtool wrappers anyway? 
> >     
> >     It's not clear to me when exactly the wrappers are generated and when they aren't
> 
> Benjamin Bannier wrote:
>     The libtool wrappers (which set up the env to consume dynamic libraries built as
part of the build) are generated so executables can be run from the build tree, without installing.
They are never installed. OTOH, executables built in autotools projects without libtool wrappers
cannot be installed as they are not correctly linked (they'd depend on files from the build
tree, not from the install prefix).
>     
>     Dropping.
> 
> Gilbert Song wrote:
>     @Joseph, in this case, we don't need to disable libtool wrappers since --enable-optimize
would make sure there is no .sh init helper generated.

@gilbert, that is incorrect, whether libtool wrappers are used or not is completely orthogonal
to the used optimization level.

One must never disable libtool wrappers when planning to install the created binary artifacts.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70295/#review214019
-----------------------------------------------------------


On March 25, 2019, 4:09 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70295/
> -----------------------------------------------------------
> 
> (Updated March 25, 2019, 4:09 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-9677
>     https://issues.apache.org/jira/browse/MESOS-9677
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We enable this flag since with it disabled certain public functions
> are not available making it hard to e.g., write modules against this
> version of Mesos.
> 
> While launcher sealing depends on a recent kernel, the platform we
> build RPMs for already satisfies the requirements.
> 
> 
> Diffs
> -----
> 
>   support/packaging/centos/mesos.spec de905fda3366be5904a0aec8249abcc53b0af9a0 
> 
> 
> Diff: https://reviews.apache.org/r/70295/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message