mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70319: Added a `createQuantitiesMap` method in `ResourceQuantities`.
Date Wed, 27 Mar 2019 14:41:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70319/#review214107
-----------------------------------------------------------



See my comment in the next review about avoiding this

- Benjamin Mahler


On March 27, 2019, 5:21 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70319/
> -----------------------------------------------------------
> 
> (Updated March 27, 2019, 5:21 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The method returns a `hashmap` of name and quantity pairs.
> This is used where callers want to have their own copy of the
> quantities and apply direct mutation.
> 
> 
> Diffs
> -----
> 
>   src/common/resource_quantities.hpp db4f5afb9f617e27bd08756020b4bcf0bd92dc66 
>   src/common/resource_quantities.cpp 9ae5d9f4aefde81cde7463a7ce118c65a68fc0db 
> 
> 
> Diff: https://reviews.apache.org/r/70319/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message