mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James DeFelice <james.defel...@gmail.com>
Subject Re: Review Request 70295: Enabled launcher sealing for RPM packages.
Date Wed, 27 Mar 2019 12:57:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70295/#review214102
-----------------------------------------------------------




support/packaging/centos/mesos.spec
Lines 94 (patched)
<https://reviews.apache.org/r/70295/#comment300274>

    we probably want to conditionally enable this depending on the centos version. for example
I don't think el6 ships w/ the necessary kernel support for launcher-sealing, but I think
that el7 does.
    
    see https://fedoraproject.org/wiki/Packaging:DistTag


- James DeFelice


On March 25, 2019, 3:09 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70295/
> -----------------------------------------------------------
> 
> (Updated March 25, 2019, 3:09 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-9677
>     https://issues.apache.org/jira/browse/MESOS-9677
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We enable this flag since with it disabled certain public functions
> are not available making it hard to e.g., write modules against this
> version of Mesos.
> 
> While launcher sealing depends on a recent kernel, the platform we
> build RPMs for already satisfies the requirements.
> 
> 
> Diffs
> -----
> 
>   support/packaging/centos/mesos.spec de905fda3366be5904a0aec8249abcc53b0af9a0 
> 
> 
> Diff: https://reviews.apache.org/r/70295/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message