mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70316: Updated test `ImportPreprovisionedVolume` for better code coverage.
Date Wed, 27 Mar 2019 11:00:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70316/#review214094
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/storage_local_resource_provider_tests.cpp
Lines 2922-2923 (patched)
<https://reviews.apache.org/r/70316/#comment300263>

    `s/reregistration/registration/`?



src/tests/storage_local_resource_provider_tests.cpp
Lines 2931 (patched)
<https://reviews.apache.org/r/70316/#comment300264>

    Is this related to above comment block?



src/tests/storage_local_resource_provider_tests.cpp
Lines 3028 (patched)
<https://reviews.apache.org/r/70316/#comment300265>

    Add a comment here documenting what triggered this allocation.



src/tests/storage_local_resource_provider_tests.cpp
Lines 3050 (patched)
<https://reviews.apache.org/r/70316/#comment300266>

    Let's add an assertion that the range resulting from the filter is actually non-empty.



src/tests/storage_local_resource_provider_tests.cpp
Line 3007 (original), 3054 (patched)
<https://reviews.apache.org/r/70316/#comment300267>

    Ditto.



src/tests/storage_local_resource_provider_tests.cpp
Line 3008 (original), 3071 (patched)
<https://reviews.apache.org/r/70316/#comment300268>

    Document what triggered the allocation.


- Benjamin Bannier


On March 27, 2019, 4:45 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70316/
> -----------------------------------------------------------
> 
> (Updated March 27, 2019, 4:45 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9540
>     https://issues.apache.org/jira/browse/MESOS-9540
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch renames `ImportPreprovisionedVolume` to
> `CreateDestroyPreprovisionedVolume` add tests two additional scenarios:
> 
> * `CREATE_DISK` with an unknown profile.
> 
> * `DESTROY_DISK` with a `RAW` disk.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87

> 
> 
> Diff: https://reviews.apache.org/r/70316/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message