mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70315: Added authorization for applying `DESTROY_DISK` on `RAW` disks.
Date Wed, 27 Mar 2019 10:03:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70315/#review214093
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/authorizer/acls.proto
Line 1 (original), 1 (patched)
<https://reviews.apache.org/r/70315/#comment300261>

    Looks like we neglected updating `docs/examples/acls_template.json` previously, could
you fix that?



src/tests/authorization_tests.cpp
Lines 7052-7064 (patched)
<https://reviews.apache.org/r/70315/#comment300262>

    Once should be enough?


- Benjamin Bannier


On March 27, 2019, 3:09 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70315/
> -----------------------------------------------------------
> 
> (Updated March 27, 2019, 3:09 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9540
>     https://issues.apache.org/jira/browse/MESOS-9540
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authorization for applying `DESTROY_DISK` on `RAW` disks.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/acls.proto 4c3f2907a25c2920a0f382e3937898774bbf49fd 
>   include/mesos/authorizer/authorizer.proto f9060531cf1f6bc60786e6d6e6b87310f1bc0927

>   src/authorizer/local/authorizer.cpp 85e18b958932fca74f7860bb19b178835a1636f9 
>   src/master/master.cpp b9db4ffd4ee8ea4a8e44a35d1afb6c1b8e03d74d 
>   src/tests/authorization_tests.cpp e85cdb681ae2d1a9f215ce9d07a56e85346e3dab 
> 
> 
> Diff: https://reviews.apache.org/r/70315/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message