mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70313: API changes for supporting destroying `RAW` disks.
Date Wed, 27 Mar 2019 09:38:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70313/#review214090
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Bannier


On March 27, 2019, 3:38 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70313/
> -----------------------------------------------------------
> 
> (Updated March 27, 2019, 3:38 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
> 
> 
> Bugs: MESOS-9540
>     https://issues.apache.org/jira/browse/MESOS-9540
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch enables a framework to apply `DESTROY_DISK` on a `RAW` disk
> backed by a preprovisioned CSI volume. This API improvement brings the
> following benefits:
> 
> * If a `CREATE_DISK` failed because of, e.g., agent gone, but the actual
>   CSI call was finished, `DESTROY_DISK` can be used to reclaim the
>   "leaked" volume.
> 
> * If there is an agent ID change, `DESTROY_DISK` can be used to clean up
>   volumes created by the previous agent's SLRP.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 35e10f19fcaae13aedd6f0d5429442f74b5ebfbe 
>   include/mesos/v1/mesos.proto 1d751f659cb55a386067d45271af6d77493c9130 
>   src/master/validation.cpp c5f0d78182a18b0891fb85009ae1be6052a41773 
>   src/tests/master_validation_tests.cpp 7f3751aa04c127c769cfd73ecb47c714e916db41 
> 
> 
> Diff: https://reviews.apache.org/r/70313/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message