mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70223: Made `StorageLocalResourceProviderProcess` no longer exposed.
Date Wed, 27 Mar 2019 06:04:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70223/
-----------------------------------------------------------

(Updated March 27, 2019, 6:04 a.m.)


Review request for mesos, Benjamin Bannier and Jan Schlicht.


Changes
-------

Rebased and updated the description.


Bugs: MESOS-9622
    https://issues.apache.org/jira/browse/MESOS-9622


Repository: mesos


Description (updated)
-------

Since we now moved the CSI calling logics to `v0::VolumeManagerProcess`,
SLRP tests no longer rely on intercepting member function dispatches of
`StorageLocalResourceProviderProcess`, so we undo the exposure made in
r/69827 (commit e9d2a296081).


Diffs (updated)
-----

  src/Makefile.am bcafe48b2105575371464a29783bc6f3f1c2cf8d 
  src/resource_provider/storage/provider.cpp 2711503cdb58cb9b34af8c9fad0908c5f788a2af 
  src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93



Diff: https://reviews.apache.org/r/70223/diff/4/

Changes: https://reviews.apache.org/r/70223/diff/3-4/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message