mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70223: Made `StorageLocalResourceProviderProcess` no longer exposed.
Date Wed, 27 Mar 2019 06:03:46 GMT


> On March 26, 2019, 3:35 p.m., Benjamin Bannier wrote:
> > Looks good!
> > 
> > What do you think about referencing `e9d2a296081` instead of `r/69827` in the commit
message?
> 
> Chun-Hung Hsiao wrote:
>     Hmm the SHA might change if there's a rebase before committing it into the master
branch. How about having a complete URL of r/69827?

Wait I was mistaken. Yeah sure let me do that.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70223/#review214052
-----------------------------------------------------------


On March 16, 2019, 12:02 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70223/
> -----------------------------------------------------------
> 
> (Updated March 16, 2019, 12:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
> 
> 
> Bugs: MESOS-9622
>     https://issues.apache.org/jira/browse/MESOS-9622
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since we now moved the CSI calling logics to `v0::VolumeManagerProcess`,
> SLRP tests no longer rely on intercepting member function dispatches of
> `StorageLocalResourceProviderProcess`, so we undo the exposure made in
> r/69827.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07 
>   src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519

>   src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93

> 
> 
> Diff: https://reviews.apache.org/r/70223/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message