mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70316: Updated test `ImportPreprovisionedVolume` for better code coverage.
Date Wed, 27 Mar 2019 05:49:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70316/#review214081
-----------------------------------------------------------




src/tests/storage_local_resource_provider_tests.cpp
Line 2962 (original), 2984 (patched)
<https://reviews.apache.org/r/70316/#comment300252>

    ```
    ../src/tests/storage_local_resource_provider_tests.cpp:2982: Failure
    Mock function called more times than expected - returning directly.
        Function call: resourceOffers(0x7ffe5a8d5fd8, @0x7efc7b1b0510 { 160-byte object <50-A5
AE-85 FC-7E 00-00 00-00 00-00 00-00 00-00 5F-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00
06-00 00-00 06-00 00-00 A0-25 01-48 FC-7E 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00
00-00 ... 10-13 00-48 FC-7E 00-00 40-13 00-48 FC-7E 00-00 D0-13 00-48 FC-7E 00-00 70-14 00-48
FC-7E 00-00 C0-32 00-48 FC-7E 00-00 00-00 00-00 00-00 00-00 20-34 00-48 FC-7E 00-00 00-00
00-00 00-00 00-00> })
             Expected: to be called once
               Actual: called twice - over-saturated and active
    ```


- Chun-Hung Hsiao


On March 27, 2019, 3:45 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70316/
> -----------------------------------------------------------
> 
> (Updated March 27, 2019, 3:45 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9540
>     https://issues.apache.org/jira/browse/MESOS-9540
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch renames `ImportPreprovisionedVolume` to
> `CreateDestroyPreprovisionedVolume` add tests two additional scenarios:
> 
> * `CREATE_DISK` with an unknown profile.
> 
> * `DESTROY_DISK` with a `RAW` disk.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87

> 
> 
> Diff: https://reviews.apache.org/r/70316/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message