mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70245: Moved CSI plugin metrics out from SLRP metrics.
Date Wed, 27 Mar 2019 04:04:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70245/
-----------------------------------------------------------

(Updated March 27, 2019, 4:04 a.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Changes
-------

Rebased on top of r70316.


Bugs: MESOS-9632
    https://issues.apache.org/jira/browse/MESOS-9632


Repository: mesos


Description
-------

This is a preliminary refactor patch for `ServiceManager` introduced in
the next patch. The CSI plugin metrics are moved out from SLRP metrics
object so the metrics can be accessed by `ServiceManager`. However, SLRP
still owns these metrics for now. Eventually we would like to decouple
metrics lifecycles from SLRP lifecycles.


Diffs (updated)
-----

  src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2 
  src/Makefile.am bcafe48b2105575371464a29783bc6f3f1c2cf8d 
  src/csi/metrics.hpp PRE-CREATION 
  src/csi/metrics.cpp PRE-CREATION 
  src/resource_provider/storage/provider.cpp 2711503cdb58cb9b34af8c9fad0908c5f788a2af 
  src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93



Diff: https://reviews.apache.org/r/70245/diff/3/

Changes: https://reviews.apache.org/r/70245/diff/2-3/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message