mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Review Request 70313: API changes for supporting destroying `RAW` disks.
Date Wed, 27 Mar 2019 02:06:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70313/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.


Bugs: MESOS-9540
    https://issues.apache.org/jira/browse/MESOS-9540


Repository: mesos


Description
-------

This patch enables a framework to apply `DESTROY_DISK` on a `RAW` disk
backed by a preprovisioned CSI volume. This API improvement brings the
following benefits:

* If a `CREATE_DISK` failed because of, e.g., agent gone, but the actual
  CSI call was finished, `DESTROY_DISK` can be used to reclaim the
  "leaked" volume.

* If there is an agent ID change, `DESTROY_DISK` can be used to clean up
  volumes created by the previous agent's SLRP.


Diffs
-----

  include/mesos/mesos.proto 099873278bfc4ca0f28ce52f329cba0903cec7cb 
  include/mesos/v1/mesos.proto 3656aa7f9d87ff3868bbc7b221d9fc7c5d7a00a3 
  src/master/validation.cpp 565d6d4ee19642b7f3f98d4b0e8e94e6e3e27004 
  src/tests/master_validation_tests.cpp 9568d39accb00eec68b622fdc7f02249fefbc063 


Diff: https://reviews.apache.org/r/70313/diff/1/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message