mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70258: Added a unit test for CSI `evolve` and `devolve` helpers.
Date Tue, 26 Mar 2019 17:31:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70258/#review214058
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/csi_utils_tests.cpp
Lines 1 (patched)
<https://reviews.apache.org/r/70258/#comment300237>

    Please consider squashing this with https://reviews.apache.org/r/70247/.


- Benjamin Bannier


On March 20, 2019, 10:37 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70258/
> -----------------------------------------------------------
> 
> (Updated March 20, 2019, 10:37 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
> 
> 
> Bugs: MESOS-9625
>     https://issues.apache.org/jira/browse/MESOS-9625
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a unit test for CSI `evolve` and `devolve` helpers.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07 
>   src/tests/CMakeLists.txt 807ed1c7ee1c7d5582b8aa2e7d0f9e582f47fc49 
>   src/tests/csi_utils_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70258/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message