mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70285: Implemented the remaining methods of v0 `VolumeManager`.
Date Tue, 26 Mar 2019 15:36:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70285/#review214054
-----------------------------------------------------------


Ship it!




Looks good, but it would be great to actually excercise and test this.

- Benjamin Bannier


On March 23, 2019, 12:36 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70285/
> -----------------------------------------------------------
> 
> (Updated March 23, 2019, 12:36 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9622
>     https://issues.apache.org/jira/browse/MESOS-9622
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch completes the v0 `VolumeManager` by properly implemented the
> `attachVolume`, `detachVolume` and `unpublishVolume` functions that are
> not used by SLRP.
> 
> 
> Diffs
> -----
> 
>   src/csi/v0_volume_manager.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70285/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message