mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70165: Fixed operator operation handling with resource provider resources.
Date Tue, 26 Mar 2019 11:36:16 GMT


> On March 18, 2019, 1:09 p.m., Benjamin Bannier wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 5496 (patched)
> > <https://reviews.apache.org/r/70165/diff/3/?file=2130372#file2130372line5496>
> >
> >     Even though above we wait for the second `UpdateSlaveMessage` we might still
never get the offers we expect here.
> >     
> >     I was able to break this test with `stress-ng` in less than 100 iterations.
/cc @chun
> 
> Jan Schlicht wrote:
>     This seems to affect other SLRP tests as well. We need a better way to start Mesos
with a SLRP and wait for it to be ready.

Filed https://issues.apache.org/jira/browse/MESOS-9678.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70165/#review213771
-----------------------------------------------------------


On March 26, 2019, 12:26 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70165/
> -----------------------------------------------------------
> 
> (Updated March 26, 2019, 12:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9612
>     https://issues.apache.org/jira/browse/MESOS-9612
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The resource provider manager didn't allow operations originating from
> operator API calls. For speculatively applied operations, this is
> allowed now.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/manager.cpp 7d3338ea7fbf330a25416f848db7742ad1bea52f 
>   src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87

> 
> 
> Diff: https://reviews.apache.org/r/70165/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message