mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 70288: Supported docker manifest v2 schema2.
Date Tue, 26 Mar 2019 08:06:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70288/#review214032
-----------------------------------------------------------



I think we need unit test to verify the behavior of v2 s2 image with force pulling enabled
and disabled.


src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
Lines 545 (patched)
<https://reviews.apache.org/r/70288/#comment300199>

    We should not do this if `manifest.config()` is already in the storeDir, otherwise launching
a container with an image which is already pulled and with force pulling enabled will fail:
    ```
    Failed to launch container: Failed to move the layer manifest from '/opt/qzhang/mesos/store/docker/staging/kOP3Sb/sha256:d8233ab899d419c58cf3634c0df54ff5d8acc28f8173f09c21df4a07229e1205'
to '/opt/qzhang/mesos/store/docker/staging/kOP3Sb/sha256:697743189b6d255069caf6c455be10c7f8cae8076c6f94d224ae15cd41420e87/json':
No such file or directory
    ```



src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
Lines 633 (patched)
<https://reviews.apache.org/r/70288/#comment300198>

    As I mentioned in the comment below, we should treat fetching `manifest->config()`
as part of fetching blobs rather than part of fetching manifest, that means here we need to
add `manifest->config().digest()` into `digests` if it is not already in the storeDir.



src/uri/fetchers/docker.cpp
Line 931 (original), 819-822 (patched)
<https://reviews.apache.org/r/70288/#comment300197>

    So here we always download `manifest->config()` regardless `uri.scheme()`. But in the
case that an image has been pulled to launch a container and then we use that image to launch
another container, we will download `manifest->config()` again even it is already in storeDir,
that's a duplicated download to me.
    
    Basically I think we should treat fetching `manifest->config()` as part of fetching
blobs rather than part of fetching manifest.


- Qian Zhang


On March 24, 2019, 12:33 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70288/
> -----------------------------------------------------------
> 
> (Updated March 24, 2019, 12:33 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Ilya Pronin, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6934
>     https://issues.apache.org/jira/browse/MESOS-6934
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported docker manifest v2 schema2.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp a5683e3fe15dd35596122fcc0c580ae9d3adf7f2

>   src/tests/containerizer/provisioner_docker_tests.cpp a2a7f11eeb533d7790890988061612e11a798067

>   src/uri/fetchers/docker.cpp a87d7f086378539e6c8048e935389919a1164fbc 
> 
> 
> Diff: https://reviews.apache.org/r/70288/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message