mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <>
Subject Re: Review Request 70168: Refactored SLRP with `ServiceManager` to manage container lifecycles.
Date Tue, 26 Mar 2019 05:00:01 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 26, 2019, 5 a.m.)

Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Addressed Benjamin's comment and removed an unnecessary header inclusion.

Bugs: MESOS-9632

Repository: mesos


Container management is moved out from SLRP to `ServiceManager`. It is
agnostic to CSI versions, so can be used to manage plugin containers for
both CSI v0 and v1 plugins.

This patch squashes the changes from r/70169.

Diffs (updated)

  src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2 
  src/ d451d7cabe3bf5d4f5039cfac5de1b03ef891d07 
  src/csi/service_manager.hpp PRE-CREATION 
  src/csi/service_manager.cpp PRE-CREATION 
  src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519 
  src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93




Testing done later in chain.


Chun-Hung Hsiao

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message