mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 70264: Reordered hash definitions in the type utils.
Date Mon, 25 Mar 2019 22:53:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70264/#review214011
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On March 21, 2019, 3:25 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70264/
> -----------------------------------------------------------
> 
> (Updated March 21, 2019, 3:25 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Joseph Wu.
> 
> 
> Bugs: MESOS-9318
>     https://issues.apache.org/jira/browse/MESOS-9318
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch reorders the hash template specializations so
> that they are in alphabetical order, with the specialization
> for a `std::pair` moved to the end so that hashes of
> combinations of types can be grouped together after the
> definitions for the individual types.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp acf5ba8e4db85bcb5e9370ed23d7d16260905e01 
> 
> 
> Diff: https://reviews.apache.org/r/70264/diff/1/
> 
> 
> Testing
> -------
> 
> Testing details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message