mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70279: Updated quota overcommit message to include total quota and capacity.
Date Mon, 25 Mar 2019 21:46:40 GMT


> On March 25, 2019, 12:08 a.m., Meng Zhu wrote:
> > src/master/quota_handler.cpp
> > Lines 223-225 (original), 223-228 (patched)
> > <https://reviews.apache.org/r/70279/diff/1/?file=2133535#file2133535line223>
> >
> >     The TODO is a good point, I think we can just include the existing portion and
the new portion in the message:
> >     
> >     "Total quota guarantees exceed cluster capacity '" + stringify(...) + "': existing
quota guarantee '" + stringify(...) + "', new guarantee request '" + stringify(...) + "'"

The reason I left it as a TODO was because I needed to update `QuotaTree` to support removal
or updating of an existing quota. That would allow us to efficiently compute the old and new
quota at the start of this function without having to build two `QuotaTree`s for before vs
after, which seemed cumbersome and inefficient.

Did you have a specific code suggestion for this patch? (e.g. let's build a second quota tree
before printing the error and follow up by removing it) Or do you agree we should follow up
by enhancing `QuotaTree` and then enhacing this message? I'm ok either way


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70279/#review213962
-----------------------------------------------------------


On March 22, 2019, 3:54 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70279/
> -----------------------------------------------------------
> 
> (Updated March 22, 2019, 3:54 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Meng Zhu.
> 
> 
> Bugs: MESOS-9292
>     https://issues.apache.org/jira/browse/MESOS-9292
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Per MESOS-9292, users would find it helpful for the quota overcommit
> error message to include more information about the cluster capactiy
> vs total quota guarantees.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 2dcfdcaf836f21d7d39b5ef5c36de0db25ca7517 
>   src/tests/master_quota_tests.cpp 3e7a94cad94b64faf01e73f880281d24098fadbd 
> 
> 
> Diff: https://reviews.apache.org/r/70279/diff/1/
> 
> 
> Testing
> -------
> 
> Updated a test.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message