mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 70294: Removed comment about multiple attempts to remove agents.
Date Mon, 25 Mar 2019 16:01:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70294/#review213992
-----------------------------------------------------------



PASS: Mesos patch 70294 was successfully built and tested.

Reviews applied: `['70294']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3009/mesos-review-70294

- Mesos Reviewbot Windows


On March 25, 2019, 1:04 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70294/
> -----------------------------------------------------------
> 
> (Updated March 25, 2019, 1:04 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed a comment that implied that multiple consecutive calls
> to `Master::removeSlave()` would be highly unexpected.
> 
> Both call sites do not seem to contain any checks against
> the `removed` set, so it's not clear why the comment was assuming
> that.
> 
> Barring additional clarifications, the comment seems to be more
> confusing than clearing things up.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 9c4a9e83da94535873d72c902835f229c4f96320 
> 
> 
> Diff: https://reviews.apache.org/r/70294/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message