mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70216: Cleanup the recovery logic for refactoring SLRP.
Date Mon, 25 Mar 2019 11:46:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70216/#review213977
-----------------------------------------------------------


Fix it, then Ship it!




Thanks for the patch reorganization, this has less noise now and is not as hard to understand
anymore.


src/resource_provider/storage/provider.cpp
Lines 615 (patched)
<https://reviews.apache.org/r/70216/#comment300118>

    `[this]`



src/resource_provider/storage/provider.cpp
Line 618 (original)
<https://reviews.apache.org/r/70216/#comment300120>

    WE are we not checkpointing this anymore since it was always a no-op anyway, right?



src/resource_provider/storage/provider.cpp
Line 1736 (original), 1553 (patched)
<https://reviews.apache.org/r/70216/#comment300123>

    Should we add a message, here and below?



src/resource_provider/storage/provider.cpp
Lines 1559 (patched)
<https://reviews.apache.org/r/70216/#comment300122>

    `[this, volumeId]`


- Benjamin Bannier


On March 23, 2019, 12:31 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70216/
> -----------------------------------------------------------
> 
> (Updated March 23, 2019, 12:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9622
>     https://issues.apache.org/jira/browse/MESOS-9622
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In addition to perform volume state recovery, the `recoverVolumes`
> function also recovers service manager and preparing services now. The
> whole logic will be moved out from SLRP to v0 `VolumeManager` later.
> 
> During volume state recovery, we no longer recover all volumes to steady
> states, since transient states are properly handled in SLRP. To simplify
> the recovery logic, a `publishVolume` method that conforms to the volume
> manager's `publishVolume` is introduced.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519

>   src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93

> 
> 
> Diff: https://reviews.apache.org/r/70216/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message