mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 70272: Eliminate a copy of the master's quota during quota validation.
Date Sun, 24 Mar 2019 19:46:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70272/#review213955
-----------------------------------------------------------


Ship it!




Thanks for the cleanup.

I think ideally we should just keep the `quotaTree` in memory and remove the master `quotas`
struct (the `quotaTree` could just output a flat hashmap if needed e.g. when recovering the
allocator).
We could also add more mutating interfaces to the quotaTree (update/remove) so that when doing
heuristic check we can just:

update_quotaTree;
if validation fails: roll_back;

In addition, I imagine such trees would also be necessary when answering quota related queries
(e.g. usage).

Also there are a couple of other places that currently does the copy e.g. remove/capacityHeuristic
(you might have already updated them in the later patches)

- Meng Zhu


On March 22, 2019, 8:54 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70272/
> -----------------------------------------------------------
> 
> (Updated March 22, 2019, 8:54 a.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Rather than copying the quota map, QuotaTree also supports insertion
> of each entry. This allows us to insert each entry while ensuring
> that the mutated role gets inserted with the new value.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 2dcfdcaf836f21d7d39b5ef5c36de0db25ca7517 
> 
> 
> Diff: https://reviews.apache.org/r/70272/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message