mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 70244: Added new operation reconciliation tests.
Date Sat, 23 Mar 2019 02:43:10 GMT


> On March 21, 2019, 11:39 p.m., Joseph Wu wrote:
> > src/tests/operation_reconciliation_tests.cpp
> > Lines 1706-1707 (patched)
> > <https://reviews.apache.org/r/70244/diff/2/?file=2133044#file2133044line1706>
> >
> >     I'm not seeing a clear race in the test body.
> >     
> >     The `UpdateSlaveMessage` right before the operation reconciliation is properly
waited for before the reconciliation starts.  So the master would already know about the agent,
and the agent's RP.

I had to change the test to restart the master to clear out the operation state, and now I
drop the UpdateSlaveMessage so that the master doesn't know about the RP.


> On March 21, 2019, 11:39 p.m., Joseph Wu wrote:
> > src/tests/operation_reconciliation_tests.cpp
> > Lines 1889-1903 (patched)
> > <https://reviews.apache.org/r/70244/diff/2/?file=2133044#file2133044line1889>
> >
> >     Is it possible to intercept the message forwarded between master and agent?
 There doesn't seem to be strong evidence that the master actually asked the agent for the
latest status.

I added a FUTURE_PROTOBUF call to look for the ReconcileOperationsMessage.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/#review213894
-----------------------------------------------------------


On March 23, 2019, 2:35 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70244/
> -----------------------------------------------------------
> 
> (Updated March 23, 2019, 2:35 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph
Wu.
> 
> 
> Bugs: MESOS-9318
>     https://issues.apache.org/jira/browse/MESOS-9318
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds two new operation reconciliation tests,
> `OperationOnUnsubscribedProvider` and
> `FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
> probe scenarios relevant to MESOS-9648 and MESOS-9318.
> 
> 
> Diffs
> -----
> 
>   src/tests/operation_reconciliation_tests.cpp 8bd1dc02a74c4e6c1b97b25e73098c0b75f2d38e

> 
> 
> Diff: https://reviews.apache.org/r/70244/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*"
--gtest_repeat=-1 --gtest_break_on_failure`
> `bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1
--gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message