mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70215: Cleanup volume attaching and publishing for SLRP.
Date Fri, 22 Mar 2019 23:37:29 GMT


> On March 19, 2019, 5:06 p.m., Benjamin Bannier wrote:
> > src/csi/v0_volume_manager.cpp
> > Lines 146 (patched)
> > <https://reviews.apache.org/r/70215/diff/2/?file=2132473#file2132473line146>
> >
> >     `s/sequentialized/serialized/` here and below?
> >     
> >     _attaching_ to be consistent with other methods?

Fixed in r/70285.


> On March 19, 2019, 5:06 p.m., Benjamin Bannier wrote:
> > src/csi/v0_volume_manager.cpp
> > Lines 159 (patched)
> > <https://reviews.apache.org/r/70215/diff/2/?file=2132473#file2132473line159>
> >
> >     _detaching_?

Fixed in r/70285.


> On March 19, 2019, 5:06 p.m., Benjamin Bannier wrote:
> > src/csi/v0_volume_manager.cpp
> > Lines 185 (patched)
> > <https://reviews.apache.org/r/70215/diff/2/?file=2132473#file2132473line185>
> >
> >     _unpublishing_?

Fixed in r/70285.


> On March 19, 2019, 5:06 p.m., Benjamin Bannier wrote:
> > src/csi/v0_volume_manager.cpp
> > Lines 192 (patched)
> > <https://reviews.apache.org/r/70215/diff/2/?file=2132473#file2132473line192>
> >
> >     Let's use uppercase initials for even for non-type template parameters, `s/rpc/Rpc/g`.
> >     
> >     Here and below.

Fixed in r/70222.


> On March 19, 2019, 5:06 p.m., Benjamin Bannier wrote:
> > src/csi/v0_volume_manager.cpp
> > Lines 202 (patched)
> > <https://reviews.apache.org/r/70215/diff/2/?file=2132473#file2132473line202>
> >
> >     Break line before `.then`.

Fixed in r/70222.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70215/#review213808
-----------------------------------------------------------


On March 22, 2019, 6:18 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70215/
> -----------------------------------------------------------
> 
> (Updated March 22, 2019, 6:18 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9622
>     https://issues.apache.org/jira/browse/MESOS-9622
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch introduces methods for volume attaching and publishing that
> conform to `VolumeManager`'s public interface in SLRP, and cleans up
> SLRP based on these functions. They will be moved out from SLRP to v0
> `VolumeManager` later.
> 
> Volume attaching and publishing are implemented with internal helpers,
> each individually deals with one steady and two transient states, and
> makes a proper CSI call to achieve its goal state. If the given volume
> is not in the designed state, it would recursively call other helpers
> to transition the volume to the designed state first.
> 
> These helper functions are serialized through the volume's own sequence
> to avoid racing operations on the same volume.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519

>   src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93

> 
> 
> Diff: https://reviews.apache.org/r/70215/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message