mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 70243: Improved operation reconciliation for unsubscribed resource providers.
Date Fri, 22 Mar 2019 21:10:08 GMT


> On March 21, 2019, 11:18 p.m., Joseph Wu wrote:
> > src/resource_provider/manager.cpp
> > Lines 626-628 (patched)
> > <https://reviews.apache.org/r/70243/diff/1/?file=2132878#file2132878line626>
> >
> >     Is the `SlaveID` field here meant to be blank?  I thought only external resource
providers could omit this field.

Yea the RP manager doesn't have the agent ID so the agent injects it before forwarding to
the master (that code is already in place: https://github.com/apache/mesos/blob/4580834471fb3bc0b95e2b96e04a63d34faef724/src/slave/slave.cpp#L8250-L8254).
I've added a comment to that effect.


> On March 21, 2019, 11:18 p.m., Joseph Wu wrote:
> > src/slave/slave.cpp
> > Lines 4517-4527 (patched)
> > <https://reviews.apache.org/r/70243/diff/1/?file=2132879#file2132879line4517>
> >
> >     You could probably do without the ternary:
> >     ```
> >     Option<UUID> operationUuid;
> >     if (operation.has_operation_uuid()) {
> >       operationUuid = operation.operation_uuid();
> >     } else if (
> >         operation.has_operation_id() && 
> >         operationIds.contains(operation.operation_id())) {
> >       operationUuid = operationIds.at(operation.operation_id());
> >     }
> >     ```

Good point. Had to tweak a bit now that this map is indexed by (FrameworkID, OperationID).


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70243/#review213892
-----------------------------------------------------------


On March 22, 2019, 9:09 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70243/
> -----------------------------------------------------------
> 
> (Updated March 22, 2019, 9:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph
Wu.
> 
> 
> Bugs: MESOS-9318
>     https://issues.apache.org/jira/browse/MESOS-9318
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the operation reconciliation pipeline to
> forward some framework-initiated reconciliation requests to
> the agent. In cases where an explicit reconciliation request
> specifies an operation which is not recognized on a resource
> provider which is also not recognized, the master will
> forward the request to the agent so that the resource
> provider manager can satisfy the request based on whether or
> not the resource provider has been seen before.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 9c4a9e83da94535873d72c902835f229c4f96320 
>   src/messages/messages.proto 633dddbaa874550f7f0d9513c608ed75b18059a8 
>   src/resource_provider/manager.cpp 7d3338ea7fbf330a25416f848db7742ad1bea52f 
>   src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25 
> 
> 
> Diff: https://reviews.apache.org/r/70243/diff/3/
> 
> 
> Testing
> -------
> 
> Testing details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message