mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Review Request 70283: Improved handling of resources consumed by orphan operations.
Date Fri, 22 Mar 2019 20:37:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70283/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Greg Mann, Joseph Wu, and Meng Zhu.


Bugs: MESOS-9635
    https://issues.apache.org/jira/browse/MESOS-9635


Repository: mesos


Description
-------

This patch makes the master's `UpdateSlaveMessage` handler include
resources consumed by orphan operations when calling
`allocator->addResourceProvider()`.

The change prevents some races that lead to the master reoffering the
resources consumed by the operations and makes the
`OperationReconciliationTest.AgentPendingOperationAfterMasterFailover`
test stable.


Diffs
-----

  src/master/master.cpp 9c4a9e83da94535873d72c902835f229c4f96320 


Diff: https://reviews.apache.org/r/70283/diff/1/


Testing
-------

`OperationReconciliationTest.AgentPendingOperationAfterMasterFailover` passed over 5000 iterations
under stress. Other tests still pass on GNU/Linux.


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message