mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70266: Removed a lambda to simplify `__allocate()`.
Date Fri, 22 Mar 2019 16:00:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70266/#review213915
-----------------------------------------------------------


Fix it, then Ship it!





src/master/allocator/mesos/hierarchical.cpp
Line 1725 (original), 1711-1712 (patched)
<https://reviews.apache.org/r/70266/#comment300028>

    Do we need to say tracked by the quota role sorter? The code shows this. Is there something
important about it coming from the quota role sorter here that the reader needs to know? (e.g.
since this is a quota role it must be tracked in the quota role sorter? won't it be also tracked
in the regular role sorter though?)


- Benjamin Mahler


On March 22, 2019, 6:13 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70266/
> -----------------------------------------------------------
> 
> (Updated March 22, 2019, 6:13 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed a lambda to simplify `__allocate()`.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp c9cf704f046c0f08131ac3f2fee54f4b649eabff

> 
> 
> Diff: https://reviews.apache.org/r/70266/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message