mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 70276: Included RP resources / static reservations in quota capacity check.
Date Fri, 22 Mar 2019 15:54:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70276/
-----------------------------------------------------------

Review request for mesos and Meng Zhu.


Bugs: MESOS-7883
    https://issues.apache.org/jira/browse/MESOS-7883


Repository: mesos


Description
-------

Static reservations and resource provider resources both count towards
quota consumption and should therefore be included in the quota
capacity check.

Note also that this renames the function to be an "overcommit" check
rather than making any suggestions of being a "satisfiability" check.
The latter is far more complex to implement properly, and the current
quota API design includes a simple overcommit check rather than any
attempt as satisfiability checking.


Diffs
-----

  src/master/master.hpp 77be494d1ca2d3cd79ab033e41a5ff66c0225f79 
  src/master/quota_handler.cpp 2dcfdcaf836f21d7d39b5ef5c36de0db25ca7517 


Diff: https://reviews.apache.org/r/70276/diff/1/


Testing
-------

Added a test in the subsequent patch.


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message