mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70268: Removed `limits` from `QuotaInfo` and `QuotaRequest` protobuf.
Date Fri, 22 Mar 2019 09:07:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70268/#review213911
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70266, 70267, 70268]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On March 22, 2019, 6:13 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70268/
> -----------------------------------------------------------
> 
> (Updated March 22, 2019, 6:13 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9604
>     https://issues.apache.org/jira/browse/MESOS-9604
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `Limits` was added as an experimental field and the
> related calls were not implementation complete.
> `QuotaConfig` has been added where limits can be
> specified. This patch cleans up the experimental
> field and related validation and tests.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 34d4b697a78464f6cbc0ec2c3c6e117690dc2917 
>   include/mesos/v1/quota/quota.proto 8a6a64a5e6d7b7986f33cf3ef85609dbce1ff363 
>   src/master/quota.cpp 62b788f504256b2e81070c714428f8dd26d604b5 
>   src/tests/master_quota_tests.cpp 3e7a94cad94b64faf01e73f880281d24098fadbd 
> 
> 
> Diff: https://reviews.apache.org/r/70268/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message