mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <>
Subject Re: Review Request 70217: Cleanup volume creation, validation and deletion for SLRP.
Date Fri, 22 Mar 2019 06:19:37 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 22, 2019, 6:19 a.m.)

Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Restructured the refactoring.

Summary (updated)

Cleanup volume creation, validation and deletion for SLRP.

Bugs: MESOS-9622

Repository: mesos

Description (updated)

This patch introduces methods for volume creation, validation and
deletion that conform to `VolumeManager`'s public interface in SLRP, and
cleans up SLRP based on these functions. They will be moved out from
SLRP to v0 `VolumeManager` later.

Specifically, volume deletion now supports deleting untracked volumes.

Diffs (updated)

  src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519 
  src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93




make check


Chun-Hung Hsiao

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message