mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 70243: Improved operation reconciliation for unsubscribed resource providers.
Date Fri, 22 Mar 2019 01:24:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70243/#review213896
-----------------------------------------------------------




include/mesos/resource_provider/resource_provider.proto
Lines 101-104 (patched)
<https://reviews.apache.org/r/70243/#comment300013>

    I think we should document somewhere (either protos or in the reconciliation handlers,
or maybe in both places?) the difference in semantics, i.e., exactly which cases are handled
differently depending on who initiated the reconciliation request.



src/master/master.cpp
Lines 9684-9693 (patched)
<https://reviews.apache.org/r/70243/#comment300008>

    Nit: I think the following version would be more concise:
    
    ```
    ReconcileOperationsMessage::Operation* forwardedOperation = reconciliationMessage.add_operations();
    forwardedOperation->mutable_operation_id()
      ->CopyFrom(operation.operation_id());
    if (resourceProviderId.isSome()) {
      forwardedOperation->mutable_resource_provider_id()
        ->CopyFrom(resourceProviderId.get());
    }
    ```



src/slave/slave.cpp
Lines 4524-4525 (patched)
<https://reviews.apache.org/r/70243/#comment300011>

    Nit:
    
    ```
          } else if (operationId.isSome() &&                                     
                              operationIds.contains(operationId.get())) {
    ```
    
    But I like Joseph's suggestion better =).


- Gastón Kleiman


On March 21, 2019, 3:26 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70243/
> -----------------------------------------------------------
> 
> (Updated March 21, 2019, 3:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph
Wu.
> 
> 
> Bugs: MESOS-9318
>     https://issues.apache.org/jira/browse/MESOS-9318
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the operation reconciliation pipeline to
> forward some framework-initiated reconciliation requests to
> the agent. In cases where an explicit reconciliation request
> specifies an operation which is not recognized on a resource
> provider which is also not recognized, the master will
> forward the request to the agent so that the resource
> provider manager can satisfy the request based on whether or
> not the resource provider has been seen before.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resource_provider/resource_provider.proto 5ea9e2009209b1609619874ebd63cb1e2e698434

>   src/master/master.cpp 9c4a9e83da94535873d72c902835f229c4f96320 
>   src/messages/messages.proto 633dddbaa874550f7f0d9513c608ed75b18059a8 
>   src/resource_provider/manager.cpp 7d3338ea7fbf330a25416f848db7742ad1bea52f 
>   src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25 
> 
> 
> Diff: https://reviews.apache.org/r/70243/diff/2/
> 
> 
> Testing
> -------
> 
> Testing details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message