mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 70244: Added new operation reconciliation tests.
Date Thu, 21 Mar 2019 23:39:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70244/#review213894
-----------------------------------------------------------



+1 on the first test.  Some questions on the second one.


src/tests/operation_reconciliation_tests.cpp
Lines 1576-1578 (patched)
<https://reviews.apache.org/r/70244/#comment300007>

    Extra newline.  Although I think this is a copy-pasta error in this file or in similar
tests.



src/tests/operation_reconciliation_tests.cpp
Lines 1706-1707 (patched)
<https://reviews.apache.org/r/70244/#comment300009>

    I'm not seeing a clear race in the test body.
    
    The `UpdateSlaveMessage` right before the operation reconciliation is properly waited
for before the reconciliation starts.  So the master would already know about the agent, and
the agent's RP.



src/tests/operation_reconciliation_tests.cpp
Lines 1889-1903 (patched)
<https://reviews.apache.org/r/70244/#comment300010>

    Is it possible to intercept the message forwarded between master and agent?  There doesn't
seem to be strong evidence that the master actually asked the agent for the latest status.


- Joseph Wu


On March 20, 2019, 12:47 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70244/
> -----------------------------------------------------------
> 
> (Updated March 20, 2019, 12:47 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph
Wu.
> 
> 
> Bugs: MESOS-9318
>     https://issues.apache.org/jira/browse/MESOS-9318
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds two new operation reconciliation tests,
> `OperationOnUnsubscribedProvider` and
> `FrameworkReconciliationRaceWithUpdateSlaveMessage`, to
> probe scenarios relevant to MESOS-9648 and MESOS-9318.
> 
> 
> Diffs
> -----
> 
>   src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0

> 
> 
> Diff: https://reviews.apache.org/r/70244/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*"
--gtest_repeat=-1 --gtest_break_on_failure`
> `bin/mesos-tests.sh --gtest_filter="*OperationOnUnsubscribedProvider*" --gtest_repeat=-1
--gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message