mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 70243: Improved operation reconciliation for unsubscribed resource providers.
Date Thu, 21 Mar 2019 23:18:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70243/#review213892
-----------------------------------------------------------




src/master/master.cpp
Lines 9677-9678 (patched)
<https://reviews.apache.org/r/70243/#comment300002>

    I feel like we usually try to avoid constructing entries via `operator[]`, but here it
is intentional.
    
    You can consider adding a note, so no one else thinks it is a mistake.



src/master/master.cpp
Lines 9695 (patched)
<https://reviews.apache.org/r/70243/#comment300003>

    This statement looks out of place compared to the rest of the function, so a note might
help: 
    ```
    // Defer sending the operation status update until after this loop,
    // which coagulates any reconciliation operations into combined
    // messages for the agent (`forwardedReconciliations`).
    ```



src/resource_provider/manager.cpp
Lines 626-628 (patched)
<https://reviews.apache.org/r/70243/#comment300004>

    Is the `SlaveID` field here meant to be blank?  I thought only external resource providers
could omit this field.



src/slave/slave.cpp
Lines 4517-4527 (patched)
<https://reviews.apache.org/r/70243/#comment300006>

    You could probably do without the ternary:
    ```
    Option<UUID> operationUuid;
    if (operation.has_operation_uuid()) {
      operationUuid = operation.operation_uuid();
    } else if (
        operation.has_operation_id() && 
        operationIds.contains(operation.operation_id())) {
      operationUuid = operationIds.at(operation.operation_id());
    }
    ```


- Joseph Wu


On March 21, 2019, 3:26 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70243/
> -----------------------------------------------------------
> 
> (Updated March 21, 2019, 3:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gastón Kleiman, and Joseph
Wu.
> 
> 
> Bugs: MESOS-9318
>     https://issues.apache.org/jira/browse/MESOS-9318
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the operation reconciliation pipeline to
> forward some framework-initiated reconciliation requests to
> the agent. In cases where an explicit reconciliation request
> specifies an operation which is not recognized on a resource
> provider which is also not recognized, the master will
> forward the request to the agent so that the resource
> provider manager can satisfy the request based on whether or
> not the resource provider has been seen before.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resource_provider/resource_provider.proto 5ea9e2009209b1609619874ebd63cb1e2e698434

>   src/master/master.cpp 9c4a9e83da94535873d72c902835f229c4f96320 
>   src/messages/messages.proto 633dddbaa874550f7f0d9513c608ed75b18059a8 
>   src/resource_provider/manager.cpp 7d3338ea7fbf330a25416f848db7742ad1bea52f 
>   src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25 
> 
> 
> Diff: https://reviews.apache.org/r/70243/diff/2/
> 
> 
> Testing
> -------
> 
> Testing details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message