mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 70242: Tracked operation IDs in the agent.
Date Thu, 21 Mar 2019 21:33:22 GMT


> On March 21, 2019, 8:27 p.m., Joseph Wu wrote:
> > src/slave/slave.hpp
> > Lines 875-878 (patched)
> > <https://reviews.apache.org/r/70242/diff/1/?file=2132873#file2132873line875>
> >
> >     Aren't these IDs only unique within a Framework's scope?
> >     
> >     Two frameworks could presumably launch an operation with the same ID, on the
same agent.  
> >     
> >     Looks like the master stores a similar mapping in the Framework struct, so there
is no possibility of overwrite there.

Whoops :D Thanks Joseph!!! I'll try changing this to a `hashmap<std::pair<FrameworkID,
OperationID>, UUID>`, with a note to put the map in the framework struct once MESOS-8582
is resolved.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70242/#review213891
-----------------------------------------------------------


On March 20, 2019, 2:21 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70242/
> -----------------------------------------------------------
> 
> (Updated March 20, 2019, 2:21 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Joseph Wu.
> 
> 
> Bugs: MESOS-9318
>     https://issues.apache.org/jira/browse/MESOS-9318
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the agent to track operation IDs in a
> hashmap. This map will be used to satisfy some reconciliation
> requests which are forwarded from the master, when the agent
> must be able to find the internal operation UUID for an
> operation which the master did not recognize.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 271593460b0aaeb8dfa0b1659e4365919e0c32d5 
>   src/slave/slave.cpp 36424f89a8c1f183febabcc9582975dd21213c25 
> 
> 
> Diff: https://reviews.apache.org/r/70242/diff/1/
> 
> 
> Testing
> -------
> 
> Testing details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message