mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70262: Added a new 'iterable_queue' template to stout.
Date Thu, 21 Mar 2019 13:02:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70262/#review213881
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70262]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On March 21, 2019, 3:57 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70262/
> -----------------------------------------------------------
> 
> (Updated March 21, 2019, 3:57 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This template exposes the iterator interface to a `std::queue`s
> underlying container.
> 
> The motivation for this is so it can be used in the `received()`
> callback of Mesos framework using the v1 API, to allow iterating
> over all received events.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/iterable_queue.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70262/diff/1/
> 
> 
> Testing
> -------
> 
> Will add a unit test if we have consensus to move forward with adding this.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message