mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 70233: Allowed for optionally unbundled ZooKeeper for CMake builds.
Date Wed, 20 Mar 2019 23:23:03 GMT


> On March 19, 2019, 11:07 p.m., Joseph Wu wrote:
> > 3rdparty/cmake/FindZOOKEEPER.cmake
> > Lines 50 (patched)
> > <https://reviews.apache.org/r/70233/diff/1/?file=2132719#file2132719line50>
> >
> >     I wonder if it is worth adding a note here, restating bits of the blurb here:
> >     https://github.com/apache/zookeeper/blob/master/zookeeper-client/zookeeper-client-c/README#L26-L32
> >     
> >     We don't have a note in the autotools build.

Yeah, why not - its a good note...


> On March 19, 2019, 11:07 p.m., Joseph Wu wrote:
> > cmake/CompilationConfigure.cmake
> > Lines 115 (patched)
> > <https://reviews.apache.org/r/70233/diff/1/?file=2132720#file2132720line115>
> >
> >     Using a Windows style path here is... a bit funny to me.  Nothing wrong with
it though.

You are perfectly right, the last few times I followed this pattern, I smiled :D.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70233/#review213810
-----------------------------------------------------------


On March 19, 2019, 12:11 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70233/
> -----------------------------------------------------------
> 
> (Updated March 19, 2019, 12:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Bugs: MESOS-9662
>     https://issues.apache.org/jira/browse/MESOS-9662
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allowed for optionally unbundled ZooKeeper for CMake builds.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9 
>   3rdparty/cmake/FindZOOKEEPER.cmake PRE-CREATION 
>   cmake/CompilationConfigure.cmake d9c1e40a59eebbb295aa993682edb8ccbf2b48f7 
> 
> 
> Diff: https://reviews.apache.org/r/70233/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message